Merge branch 'hotfix-3.2.1' into develop

[infoex-autowx.git] / infoex-autowx.py

diff --git a/infoex-autowx.py b/infoex-autowx.py
index 7ecf36eaab34e3b47fc95994489222525d32b5ac..b663163f16f5c18bc31036f9fffb2307cdbc289e 100755 (executable)
--- a/infoex-autowx.py
+++ b/infoex-autowx.py
@@ -43,7 +43,7 @@ import zeep
 import zeep.cache
 import zeep.transports
 
-__version__ = '3.1.1'
+__version__ = '3.2.1'
 
 LOG = logging.getLogger(__name__)
 LOG.setLevel(logging.NOTSET)
@@ -200,13 +200,7 @@ def main():
     iemap = setup_infoex_counterparts_mapping(station['provider'])
 
     # override units if user selected metric
-    if 'units' not in station:
-        if station['provider'] != 'python':
-            LOG.error("Please specify the units in the configuration "
-                      "file")
-            sys.exit(1)
-
-    if station['units'] == 'metric':
+    if station['provider'] != 'python' and station['units'] == 'metric':
         final_data = switch_units_to_metric(final_data, fmap)
 
     (begin_date, end_date) = setup_time_values(station)
@@ -533,15 +527,10 @@ def switch_units_to_metric(data_map, mapping):
 
     # NOTE: to update this, use the fmap<->final_data mapping laid out
     #       in setup_infoex_fields_mapping ()
-    #
-    # NOTE: this only 'works' with MesoWest for now, as the MesoWest API
-    #       itself handles the unit conversion; in the future, we will also
-    #       support NRCS unit conversion, but this must be done by this
-    #       program.
     data_map[mapping['tempMaxHourUnit']] = 'C'
     data_map[mapping['tempMinHourUnit']] = 'C'
     data_map[mapping['tempPresUnit']] = 'C'
-    data_map[mapping['precipitationGaugeUnit']] = 'C'
+    data_map[mapping['precipitationGaugeUnit']] = 'mm'
     data_map[mapping['hsUnit']] = 'cm'
     data_map[mapping['windSpeedUnit']] = 'm/s'
     data_map[mapping['windGustSpeedNumUnit']] = 'm/s'
@@ -558,7 +547,7 @@ def convert_nrcs_units_to_metric(element_cd, value):
     elif element_cd == 'SNWD':
         value = in_to_cm(value)
     elif element_cd == 'PREC':
-        value = in_to_cm(value)
+        value = in_to_mm(value)
     return value
 
 # CSV operations
@@ -611,6 +600,10 @@ def in_to_cm(inches):
     """convert inches to centimetrs"""
     return float(inches) * 2.54
 
+def in_to_mm(inches):
+    """convert inches to millimeters"""
+    return (float(inches) * 2.54) * 10.0
+
 def ms_to_mph(ms):
     """convert meters per second to miles per hour"""
     return ms * 2.236936